Skip to content

Conversation

Gentle
Copy link
Contributor

@Gentle Gentle commented Oct 3, 2025

No description provided.

@Gentle
Copy link
Contributor Author

Gentle commented Oct 3, 2025

libxz requires automake autoconf po4a and libtool, I did not check yet if those exist on CI

also zstd in particular is quite big, do we want all compression libraries?

@dicej
Copy link
Collaborator

dicej commented Oct 3, 2025

also zstd in particular is quite big, do we want all compression libraries?

libz is the most-requested one, so we should include that by default, at least. Perhaps we could exclude the other ones by default and allow the developer to optionally enable them somehow? I suspect the only way to do that would be to e.g. check an environment variable in build.rs (e.g. COMPONENTIZE_PY_ENABLE_ZSTD), which means anyone who wants zstd needs to build a custom version of componentize-py, which is awkward; not sure if there's a better way.

@Gentle
Copy link
Contributor Author

Gentle commented Oct 3, 2025

I think you can use feature flags in build.rs but that still would mean separate componentize-py versions

technically we could build cpython multiple times, making componentize-py bigger, and then adding an option for minimal, zlib-only or full runtimes

@Gentle
Copy link
Contributor Author

Gentle commented Oct 3, 2025

we agreed on Zulip to only include zlib for now

@Gentle Gentle changed the title add libz, libbz2, libzstd, libxz to cpython build add libz to cpython build Oct 3, 2025
Never underestimate how slow CI can be.

Signed-off-by: Joel Dice <[email protected]>
Copy link
Collaborator

@dicej dicej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dicej dicej merged commit 8ee5b70 into bytecodealliance:main Oct 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants